nodeSolidServer / nodeSolidServer/node-solid-server

PATCH with multiple INSERT statements do not add all data

Open
#1,113 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug test-case
Dominant language
JavaScript
Stars
1.8k
Forks
308
PR merge metrics
No merged PRs in 30d

Description

When sending the following PATCH request:

INSERT DATA {
  <https://drive.verborgh.org/solid/card#me> <http://xmlns.com/foaf/0.1/name> "Ruben1"
}
;
INSERT DATA {
  <https://drive.verborgh.org/solid/card#me> <http://xmlns.com/foaf/0.1/name> "Ruben2"
}
;
INSERT DATA {
  <https://drive.verborgh.org/solid/card#me> <http://xmlns.com/foaf/0.1/name> "Ruben3"
}
;
INSERT DATA {
  <https://drive.verborgh.org/solid/card#me> <http://xmlns.com/foaf/0.1/name> "Ruben4"
}
;
INSERT DATA {
  <https://drive.verborgh.org/solid/card#me> <http://xmlns.com/foaf/0.1/name> "Ruben5"
}
;
INSERT DATA {
  <https://drive.verborgh.org/solid/card#me> <http://xmlns.com/foaf/0.1/name> "Ruben6"
}

only some of those statements are added. A possible result is:

@prefix : <#>.
@prefix n0: <http://xmlns.com/foaf/0.1/>.

:me n0:name "Ruben1", "Ruben3", "Ruben6".

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the PATCH request shown in the issue with all six INSERT DATA statements and inspect the resulting Turtle data. Trace the request handling and update processing until you find where statements are dropped; done means all six name values are stored and the behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.