nodeSolidServer / nodeSolidServer/node-solid-server

Proxy should reuse original request's Accept headers on redirects

Open
#1,078 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.8k
Forks
308
PR merge metrics
No merged PRs in 30d

Description

When the proxy gets a redirect response from target resource, it doesn't reuse client's original Accept header on subsequent request following the Location. What ends up being returned to the client is inconsistent.

[It may be true for the other headers from the client are dropped as well, but Accept is up there on the list to make sure it works as expected.]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for proxy redirect handling and request-header forwarding, then reproduce a redirect while sending an Accept header. Check the request made after following Location and verify that the client's original Accept value is preserved; done means redirected responses are consistent with the original request.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.