Theme: Allow theme plugin to define `monacoOptions` in themes with variations
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 23.7k
- Forks
- 3.9k
- Avg merge
- 12h 23m
- Merged PRs (30d)
- 22
Description
From Slack
I hope it's not too late for this feature request.
#5659 introduced the mechanism for themes to provide multiple variants. Unfortunately, it has some limitations:
When the editor manages the scheme, Monaco swaps
vs/vs-darkand Mermaid swapsdefault/dark— per-scheme overrides aren't part of this API. The plugin'smonacoOptions/mermaidkeys still load once but don't switch with the scheme. A richer per-scheme block (variants) is the natural follow-up if needed.
Excerpt from https://github.com/node-red/node-red/issues/5534#issuecomment-4337956721
It would be great if theme plugins also had an option to define monacoOptions per color scheme.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing issue #5659 and the referenced discussion in issue #5534 to understand the existing theme-variant mechanism. Trace how theme plugins currently provide monacoOptions and how color schemes are applied. Done means theme plugins can define distinct Monaco options for each color scheme without breaking existing theme definitions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100