node-red / node-red/node-red-nodes

Broken OctetString conversion

Open
#976 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.1k
Forks
612
Avg merge
13h 57m
Merged PRs (30d)
3

Description

This conversion toString() broke the OctetString when MAC as a value is present, because must be converted to HEX.
This problem is not present in SNMP Walk, because is returning the value un-processed and make the user to deal with conversion

The value is not consistent between different SNMP nodes and force the user to use different methods to get the same value right.

https://github.com/node-red/node-red-nodes/blob/553ae44ccb55b3dd87c44d514e4068142831af4e/io/snmp/snmp.js#L257

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in io/snmp/snmp.js around line 257, as identified by the issue, and trace how OctetString values are handled by toString() compared with SNMP Walk. Confirm the behavior for a MAC-valued OctetString, then verify that the resulting value is consistently represented as HEX across the affected SNMP nodes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.