node-red / node-red/node-red-nodes

Tail node and corresponding tests don't work on Windows

Open
#698 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.1k
Forks
612
Avg merge
13h 57m
Merged PRs (30d)
3

Description

There's a comment associated with the tail node saying "Linux and windows only". Would be nice if possible to make this work for Windows.

Also, the corresponding unit test fails on Windows, not only because the actual functionality doesn't work, but because there's a timing window where we look to write to the test file but the file does't exist. This has been seen once or twice on the Travis build. Note that the test uses

fs.unlinkSync(fileToTail);

which on linux deletes the file but on windows only deletes when the running process completes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the tail node implementation and its corresponding unit test, starting with the fs.unlinkSync(fileToTail) cleanup described in the issue. Run the test on Windows and compare the tail-node behavior with Linux. Done means the node works on Windows and the test no longer depends on the file-existence timing window.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
operating-systems, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.