node-red / node-red/node-red-nodes
Pushbullet input node tries to reconnect too fast
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 612
- Avg merge
- 13h 57m
- Merged PRs (30d)
- 3
Description
Which node are you reporting an issue on?
node-red-node-pushbullet 0.0.14
What are the steps to reproduce?
I'm not sure. Maybe the Pushbullet server had a problem, maybe my network or the internet to the pushbullet server had a problem.
What happens?
The pushbullet in node had a problem connecting to the Pushbullet server:
Aug 21 15:28:54 rpi Node-RED[566]: 21 Aug 15:28:54 - [error] [pushbullet in:43cf06f2.df7d58] Error: Unexpected server response: 502
Aug 21 15:28:58 rpi Node-RED[566]: 21 Aug 15:28:58 - [error] [pushbullet in:43cf06f2.df7d58] Error: Unexpected server response: 502
Aug 21 15:29:18 rpi Node-RED[566]: 21 Aug 15:29:18 - [error] [pushbullet in:43cf06f2.df7d58] Error: Unexpected server response: 502
That's ok, it can happen, and trying it again after a few seconds also is ok. But after a few minutes, the pushbullet in node becomes a bit impatient, and the Pushbullet server answers with HTTP error 429, too many requests:
Aug 21 15:41:06 rpi Node-RED[566]: 21 Aug 15:41:06 - [error] [pushbullet in:43cf06f2.df7d58] Error: Unexpected server response: 502
Aug 21 15:41:08 rpi Node-RED[566]: 21 Aug 15:41:08 - [error] [pushbullet in:43cf06f2.df7d58] Error: Unexpected server response: 502
Aug 21 15:41:08 rpi Node-RED[566]: 21 Aug 15:41:08 - [error] [pushbullet in:43cf06f2.df7d58] Error: read ECONNRESET
Aug 21 15:41:08 rpi Node-RED[566]: 21 Aug 15:41:08 - [error] [pushbullet in:43cf06f2.df7d58] Error: read ECONNRESET
Aug 21 15:41:08 rpi Node-RED[566]: 21 Aug 15:41:08 - [error] [pushbullet in:43cf06f2.df7d58] Error: read ECONNRESET
Aug 21 15:41:08 rpi Node-RED[566]: 21 Aug 15:41:08 - [error] [pushbullet in:43cf06f2.df7d58] Error: read ECONNRESET
Aug 21 15:41:14 rpi Node-RED[566]: 21 Aug 15:41:14 - [error] [pushbullet in:43cf06f2.df7d58] Error: read ECONNRESET
Aug 21 15:41:24 rpi Node-RED[566]: 21 Aug 15:41:24 - [error] [pushbullet in:43cf06f2.df7d58] Error: Unexpected server response: 429
Aug 21 15:41:25 rpi Node-RED[566]: 21 Aug 15:41:25 - [error] [pushbullet in:43cf06f2.df7d58] Error: Unexpected server response: 429
And things get worse and worse: half an hour later, the pushbullet in node tried the request 35 times in a second (with a mix of 502 and 429 responses) and Node-RED was very unresponsive. I disabled the node and restarted Node-RED.
What do you expect to happen?
There should be not so many requests in a short time.
Please tell us about your environment:
- Node-RED version: v1.1.3
- node.js version: v10.22.0
- npm version: 6.14.6
- Platform/OS: Linux/Raspbian 5.4.51-v7l+
- Browser: Firefox
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the node-red-node-pushbullet 0.0.14 pushbullet in node and reproduce the reconnect behavior using the reported 502, 429, and ECONNRESET responses. Trace its connection retry handling and verify that failures no longer generate many requests in a short time or make Node-RED unresponsive.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100