node-red / node-red/node-red-admin
[secuity]The iteration count for the salt is too low
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 51
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Description
At the location https://github.com/node-red/node-red-admin/blob/master/lib/commands/hash.js#L27, the encryption of the salt with bcrypt.hashSync(password, 8) should have a loop count of at least 10 to ensure sufficient security.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open lib/commands/hash.js at line 27 and inspect the bcrypt.hashSync call. Update the salt iteration count to at least 10, then run the repository's available checks to confirm the hashing command still works with the revised setting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- security
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100