node-gradle / node-gradle/gradle-node-plugin

Use of Node V8 Canary

Open
#95 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Groovy
Stars
677
Forks
120
PR merge metrics
No merged PRs in 30d

Description

Is it possible to use the node version with V8 canary and how can I do it?

The problem that I see is that repository pattern is different: https://nodejs.org/download/v8-canary/

I try the follow settings:

distBaseUrl = 'https://nodejs.org/download/v8-canary/'
version = '15.0.0-v8-canary20200424f04d3357b9'

But this result in the follow exception:

java.lang.NumberFormatException: For input string: "0-v8-canary20200424f04d3357b9"
	at com.moowork.gradle.node.variant.VariantBuilder.hasWindowsZip(VariantBuilder.groovy:136)
	at com.moowork.gradle.node.variant.VariantBuilder.build(VariantBuilder.groovy:56)
	at com.moowork.gradle.node.variant.VariantBuilder$build.call(Unknown Source)
	at com.moowork.gradle.node.NodePlugin$_apply_closure1.doCall(NodePlugin.groovy:43)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the configuration with distBaseUrl and version from the issue, then inspect VariantBuilder.groovy at line 136 and the call from NodePlugin.groovy. Check how the V8 Canary version is parsed and how its repository layout differs; done means the configuration no longer raises NumberFormatException and the Canary distribution can be resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy, node.js
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.