node-gradle / node-gradle/gradle-node-plugin
OutputFiles should only look at package.json files to match yarn
Nobody has claimed this yet.
- Dominant language
- Groovy
- Stars
- 677
- Forks
- 120
- PR merge metrics
- No merged PRs in 30d
Description
Currently, the YarnInstallTask outputs contain the whole node_modules directory - https://github.com/node-gradle/gradle-node-plugin/blob/master/src/main/groovy/com/moowork/gradle/node/yarn/YarnInstallTask.groovy#L55
I wonder if anyone really gets benefit out of this - it takes a really long time for Gradle to scan through all the files in node_modules to do its up-to-date check (at least on Windows). From what I understand, yarn checks for up-to-date by looking at package.json files only, not every single source file. Would it make sense that by default, this plugin also only adds package.json to the output files?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/main/groovy/com/moowork/gradle/node/yarn/YarnInstallTask.groovy around line 55 and review how YarnInstallTask declares its outputs. Compare that behavior with the issue's description of Yarn's package.json-based checks; done means the output set no longer scans the whole node_modules tree by default and matches the intended up-to-date behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100