node-gradle / node-gradle/gradle-node-plugin
NodePlugin runs uname twice
Nobody has claimed this yet.
- Dominant language
- Groovy
- Stars
- 677
- Forks
- 120
- PR merge metrics
- No merged PRs in 30d
Description
NodePlugin runs uname twice:
-
Once on line 90 (the result is unused)
-
Again on lines 91-94
Perhaps this is intentional, but I just wanted to double check, in case it was a mistake. If it's intentional I think it would help to add a comment to explain the purpose.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/main/kotlin/com/github/gradle/node/NodePlugin.kt around lines 90-94 and inspect both uname invocations, including whether the first result is unused. Done means either eliminating the redundant invocation or documenting why both calls are intentional, then verifying the plugin checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin, nodejs
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100