node-gradle / node-gradle/gradle-node-plugin
npmInstall up-to-date check broken with fastNpmInstall
Nobody has claimed this yet.
- Dominant language
- Groovy
- Stars
- 677
- Forks
- 120
- PR merge metrics
- No merged PRs in 30d
Description
I stumbled on a weird issue with the following steps:
- Fresh git checkout, i.e. no
node_modulesdirectory present - Run task
npmInstallwith thefastNpmInstalloption enabled - Run the clean task, i.e. remove the whole
node_modulesdirectory - Run
npmInstallagain, it reports as up-to-date - Other tasks fail because
node_modulesis missing
The problem is that in step 2 the file node_modules/.package-lock.json was not recorded as output because it did not yet exist at configuration time, only after task execution. So the task has no configured outputs and won't become out of date by removing the node_modules directory.
Proposed fix: When using fastNpmInstall, do not check for existance of the file at configuration time here, instead always return the file.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/main/kotlin/com/github/gradle/node/npm/task/NpmInstallTask.kt around line 115 and inspect how fastNpmInstall determines its outputs. Reproduce the npmInstall, clean, and npmInstall sequence, then verify that removing node_modules makes the task out of date and restores the directory on execution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin, nodejs
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100