node-gradle / node-gradle/gradle-node-plugin

NpmTask workingDir should be DirectoryProperty

Open
#305 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Groovy
Stars
677
Forks
120
PR merge metrics
No merged PRs in 30d

Description

NpmTask's workingDir property is currently a RegularFileProperty but it probably should be a DirectoryProperty similar to how NodeTask's workingDir property is.

I can implement this, if you wish, but I am not sure how you would want to handle breaking compatibility with existing code.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the NpmTask and NodeTask definitions and comparing their workingDir property declarations. Determine the compatibility implications of changing NpmTask's property type, then verify that the resulting API behavior matches the issue's requested DirectoryProperty change.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy, nodejs
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.