node-gradle / node-gradle/gradle-node-plugin

Add HTTPS support to integration tests

Open
#195 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue help wanted
Dominant language
Groovy
Stars
677
Forks
120
PR merge metrics
No merged PRs in 30d

Description

With no changes in the code we've started getting failures like this:

java.lang.AssertionError: Request not found exactly once, expected:<{
          "method" : "GET",
          "path" : "/case",
          "headers" : {
            "Host" : [ "registry.npmjs.org:80" ]
          },
          "secure" : false
        }> but was:<{
          "method" : "POST",
          "path" : "/-/npm/v1/security/audits/quick",

We probably just need to disable audits in the integration tests since we're mocking for proxy testing purposes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the integration tests for proxy testing and the expectations around requests to registry.npmjs.org. Check how npm audit requests are triggered in these tests and verify the proposed audit behavior against the HTTPS-related failure. Done means the integration tests no longer fail on unexpected audit requests while proxy request coverage still passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy, nodejs
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.