node-gradle / node-gradle/gradle-node-plugin

Improve the plugin code according to Gradle recommendations

Open
#101 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Groovy
Stars
677
Forks
120
PR merge metrics
No merged PRs in 30d

Description

I suggested to Gradle some API improvements to fix issues I encountered when integrating lazy configuration in the plugin code in gradle/gradle#12974.

@big-guy made a kind of code review of the plugin and suggested us back some improvements we could do in the plugin code to improve it.

I learned multiple things and I think we should have a look to that. Some of this changes are breaking changes, I am wondering whether we should apply them now or wait for the future 4.0 version.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the recommendations and proposed improvements in gradle/gradle#12974, especially the linked comment, then inspect the plugin code that handles lazy configuration. Done means deciding which recommendations to apply, addressing any breaking changes, and documenting whether they belong now or in a future 4.0 release.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy, nodejs
Domain
build-system
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.