node-formidable / node-formidable/formidable

maxFileSize not working as it should

Open
#971 1 comment 0 reactions 1 assignee View on GitHub

@GrosSacASac is already working on this.

Since Mar 5, 2024.

Area: APIs Priority: Medium Status: Accepted Type: Bug
Dominant language
JavaScript
Stars
7.2k
Forks
689
Avg merge
3d 7h
Merged PRs (30d)
2

Description

Support plan
  • Which support plan is this issue covered by? (Community, Sponsor, Enterprise): community
  • Currently blocking your project/work? (yes/no): yes
  • Affecting a production system? (yes/no): somehow
Context
  • Node.js version: 21.6.2
  • Release Line of Formidable (Legacy, Current, Next): latest
  • Formidable exact version: latest
  • Environment (node, browser, native, OS): node
  • Used with (popular names of modules): idk
What are you trying to achieve or the steps to reproduce?

I think the maxFileSize check only happens after the file is fully uploaded, how to make it so it's immediate after bytes received exceed the set limit?

What was the result you got?

Only after file fully uploaded

What result did you expect?

Immediately after limit is reached

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.