nn1dev / nn1dev/website

Images / videos gallery dialog

Open
#147 2 comments 0 reactions 1 assignee View on GitHub

@pawelgrzybek is already working on this.

Since Nov 26, 2025.

enhancement
Dominant language
Astro
Stars
10
Forks
19
Avg merge
1d 16h
Merged PRs (30d)
2

Description

Videos and images gallery is a mess. There is so many things broken about it and the whole things needs a refactor. Some of the things that are wrong.

  • images / videos reload the whole dialog instead of exchanging the content inside the dialog
  • navigation buttons on the images carousel should preload resource on hover, or even always load the next /previous item
  • captions under the images are strangely positioned, and this complicates the markup a lot
  • naming convention and the reusability of these components looks like someone built it in 15 minutes and copied pasted bunch of stuff from somewhere else (this is precisely what i did)
  • the content of the dialog and the shell of a dialog should be better separated, now they are very tightly coupled to gallery, but it is impossible to easily adapt the dialog to reuse it for something else

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.