nmwsharp / nmwsharp/polyscope

Seting default color for NaN in `addScalarQuantity`

Open
#297 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
2.2k
Forks
242
Avg merge
11m
Merged PRs (30d)
1

Description

While debugging scalar quantities, I find myself often overlooking NaN values, because as it stands, they (seem to) get mapped to zero. It'd be nice if we could specify the color that NaN values should map to, so they're easier to distinguish. perhaps as an extra optional<glm::vec3> argument (if empty, default to current behaviour) argument would help.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the addScalarQuantity entry point and tracing how NaN values currently map to zero. Add an optional glm::vec3 color while preserving the current behavior when it is empty, then check the existing tests or examples for scalar quantity rendering and verify both paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.