Clean up CanonicalName things

Open
#16 0 comments 0 reactions 1 assignee View on GitHub

@nmwsharp is already working on this.

Since Sep 11, 2019.

Assessment

This issue has not been assessed yet.

Description

bug enhancement

I noticed some of the template use in Happly is not ideal. Go back and look closer:

  • CanonicalName<size_t> looks like it has a bug, perhaps not caught because no one uses 32bit machines?
  • Try to avoid copy when converting to canonical
  • Several places where we through runtime_errors could be compile time checks (though the compile checks might have much more confusing error message...)
Dominant language
C++
Stars
406
Forks
74
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nmwsharp/happly

All issues in nmwsharp/happly

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.