Possible typo in the stripInvalidFaceWorker() function

Open
#203 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
computer-graphics

Research direction

Open src/surface/simple_polygon_mesh.cpp around lines 548-553 and inspect SimplePolygonMesh::stripInvalidFaceWorker(). Verify whether the duplicated removeWithBadInds use should instead reference removeLowDegree; done means the unused parameter is handled correctly without changing the function's intended behavior.

Written by the indexing model from the issue text.

Description

Hi,

I noticed a possible typo in the function SimplePolygonMesh::stripInvalidFaceWorker() where the parameter removeLowDegree is unused (meanwhile removeWithBadInds is doubly used).

https://github.com/nmwsharp/geometry-central/blob/1f8a50c353e90322294c1c5aa0d411b7894f24ed/src/surface/simple_polygon_mesh.cpp#L548-L553

I think, on Line 549, that should be removeLowDegree instead of removeWithBadInds.

I don't believe this is causing any real issues. So, it' really a very minor type—just thought I’d point it out! Thanks for all your hard work in building this library!

Dominant language
C++
Stars
1.3k
Forks
183
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nmwsharp/geometry-central

All issues in nmwsharp/geometry-central

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.