nmfs-ost / nmfs-ost/stockplotr
observed values and expected values are on different rows
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 19
- Forks
- 7
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 9
Description
When running convert_output() I was expecting that observed values would be a separate column not another entry, i.e., row. For example, for index of abundance data there are multiple rows for for a given fleet/year combination, indices_observed and indices_expected. I am expecting the expected value to be in "estimated" and the input/observed value to be in "observed".
Additionally, should "indices" be "index"? I realize that we should probably change in FIMS where the label is "index_expected" to just "index" but I don't really want to change it to "indices".
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the convert_output() entry point and trace how abundance data for a fleet/year combination becomes rows and columns. Compare the indices_observed and indices_expected output with the requested observed and estimated columns, then review the FIMS index_expected naming concern. Done means the output shape and singular label are agreed and covered by the relevant checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100