nmfs-ost / nmfs-ost/ss3-user-examples

Clean up warnings in user-example files

Open
#30 1 comment 0 reactions 2 assignees View on GitHub

@e-perl-NOAA is already working on this.

Since Nov 1, 2023.

model files
Dominant language
Scheme
Stars
2
Forks
4
PR merge metrics
No merged PRs in 30d

Description

See issue #51 in the test-models repos. The models in the user-examples repo have some warnings that didn't exist (or related to model options that didn't exist) when the models were created. In most cases, the models should be changed to make the warnings go away. This will make it easier to see when new warnings appear in the future. In a few cases, the warnings themselves may need revision in the SS3 code.

Warning files for these models aren't included in the model files like they are for the test models so a text file of each warning file is included below:
empirical_wtatage_and_age_selex
selex_age_example
selex_length_example
simple
simple_long
simple_long_wtatage
simple_with_discard

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.