nmfs-ost / nmfs-ost/ss3-test-models
update compare.R to include more quantities from ss_summary.sso
Nobody has claimed this yet.
- Dominant language
- Scheme
- Stars
- 3
- Forks
- 1
- Avg merge
- 28m
- Merged PRs (30d)
- 1
Description
@Rick-Methot-NOAA identified a change in SmryBio and TotalBio quanities that jenkins was not flagging. It would be helpful to compare more values in the compare script that compares values in SS to a reference model run's ss_summary.sso in order to catch these sorts of issues. Note that the log likelihoods did not change in this case, so the issue was not detectable through other quantities.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with jenkins/shared/compare.R and inspect how it compares a Stock Synthesis run with the reference model's ss_summary.sso. Use the reported SmryBio and TotalBio change as the motivating case, then define completion as the comparison checking more relevant quantities so changes not reflected in log likelihoods are detected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- ci-cd, testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100