nmfs-ost / nmfs-ost/ss3-source-code

[Feature]: Mean recruitment adjustment

Open
#594 17 comments 0 reactions 2 assignees View on GitHub

@Cole-Monnahan-NOAA is already working on this.

Since Apr 26, 2024.

  • #699 by @Rick-Methot-NOAA — merged
benchmark - MSY in progress recruitment
Dominant language
C++
Stars
46
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Describe the solution you would like.

see discussion in #593
When using recdev option 1, the dev_vector with tuned bias adjustment forces the arithmetic mean recruitment of the time series to be consistent with the mean from the spawner-recruitment relationship.
This is because the spawner-recruitment relationship is used to produce MSY; MSY is not based on the time series of estimated recruitments.
With the transition to recommending that recdevs be based on recdev option = 2, which is not zero-centered, there is a concern that the MSY calculations will not be consistent with the mean of the recruitments.
It seems that MSY should remain based on the SRR, as adjusted by the mean deviation of the recdevs.
Solution 1: add a penalty to mean recdev to improve degree to which it is 0.0
Solution 2: base the benchmark quantities on log(R0) - mean(dev)

Describe alternatives you have considered

Rely on the sigma penalty to keep mean recruitment close enough to zero. However, it is clear that his does not always happen. A change to log(R0) can be perfectly offset by a drift in mean recruitment.

Statistical validity, if applicable

No response

Describe if this is needed for a management application

definitely important to not allow a know bias in this calculation

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.