nmfs-ost / nmfs-ost/ss3-source-code

[Feature]: Revise recdev_bias adjustment to be a customizable list of line segments

Open
#588 0 comments 0 reactions 1 assignee View on GitHub

@Rick-Methot-NOAA is already working on this.

Since Apr 17, 2024.

recruitment
Dominant language
C++
Stars
46
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Describe the solution you would like.

The bias adjustment ramp is too inflexible to track needed inflections in recruitment bias adjustment.
A better approach would allow user to enter a list of year, value entries such that a fully customizable vector can be created.
An alternative might be to enter the entire vector of se values for the estimated recdevs, perhaps even by reading the ss3.std file. From this vector, SS3 could calculate the needed bias-adjustment.

Describe alternatives you have considered

none

Statistical validity, if applicable

per Taylor and Methot (2011)

Describe if this is needed for a management application

yes, routinely.

Additional context

will need coordination with r4ss

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.