nmfs-ost / nmfs-ost/ss3-source-code

[Refactor]: create function for t=f(y,s)

Open
#578 0 comments 0 reactions 1 assignee View on GitHub

@Rick-Methot-NOAA is already working on this.

Since Mar 11, 2024.

misc. internal calc quick
Dominant language
C++
Stars
46
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Refactor request

This equation is used repeatedly. Useful to turn it into a function.
t = styr + (y - styr) * nseas + s - 1;

e.g. t = get_t(yr,s)
FUNCTION int get_t(yr,s)

Expected behavior

more concise code

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.