nmfs-ost / nmfs-ost/ss3-source-code

[Feature]: add discard body weights to wtatage.ss

Open
#575 1 comment 0 reactions 1 assignee View on GitHub

@Rick-Methot-NOAA is already working on this.

Since Feb 27, 2024.

discard & retention duplicate wishlist
Dominant language
C++
Stars
46
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Describe the solution you would like.

need for this came up in the North Sea sole 2024 assessment with Iago and Max
probably redundant issue to #81

Describe alternatives you have considered

make discard a separate fleet.
Propose doing this by re-purposing the existing field for "birthseason" to partition. It seems highly unlikely that an empirical wtatage model would ever use birthseason (aka settlement event). That is a feature designed by age-length models that are looking at details of seasonal growth.
Currently, SS3 reads values for:
#Yr Seas Sex Bio_Pattern BirthSeas Fleet
but the sex, Bio_pattern and birthseason fields combined into "g" index for the working array. So, effectively only sex is operational:

      gg = tempvec(3);
      gp = tempvec(4);
      birthseas = tempvec(5);
      g = (gg - 1) * N_GP * nseas + (gp - 1) * nseas + birthseas; //  note  cannot handle platoons
Wt_Age_t(t, f, g, a )  is working array

PROBLEM:
expected discard does not directly refer to wt_age_t, it gets discard from total catch - retained catch biomass
else if (catchunits(f) == 1) // biomass units for retained and discarded catch
{ exp_disc(f, j) = catch_fleet(t, f, 1) - catch_fleet(t, f, 3); // discard in biomass

So I see that implementing this feature would require major changes and testing with current discard models

Statistical validity, if applicable

provides flexibility to more accurately mimic the real world situation

Describe if this is needed for a management application

yes. North Sea sole

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.