nmfs-ost / nmfs-ost/ss3-source-code
[Feature]: update dynamic Bzero to work with recdev options 3&4
Open
@Rick-Methot-NOAA is already working on this.
Since Sep 26, 2023.
misc. internal calc
recruitment
- Dominant language
- C++
- Stars
- 46
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
Describe the solution you would like.
per a conversation with Arni Magnusson, dynamic Bzero may function differently if recdev option 3 or 4 is selected because with those options annual recruitment is B0 * recdev(y), so would be unaffected by steepness. With recdev option 3 & 4, the spawner-recruitment steepness enters the calculations in the objective function, rather than in the dynamics.
At this time, I do not see an obvious workaround, so we should at least add a warning to the user.
Describe alternatives you have considered
add warning
Statistical validity, if applicable
No response
Describe if this is needed for a management application
may affect management calculations
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.