[Feature]: Add capability for seasonal offset in a CPUE catchability
@Rick-Methot-NOAA is already working on this.
Since Jul 21, 2023.
Assessment
This issue has not been assessed yet.
Description
Describe the solution you would like.
I often see model configurations in which users create season-specific fleets in order to have season-specific Q, and sometimes season-specific selectivity. Most often, it is to get at season-specific Q. Addition of a capability to have season-specific Q would provide a more convenient and probably faster-executing option.
- review how seasonality in MGparms is implemented to see if extendable to Q
- consider generic capability to have seasonality in any parameter, especially selectivity parameters
Describe alternatives you have considered
The MGparm approach has specific input for each parameter type. If selected, then season parameters created to do:
if (MGparm_seas_effects(j) > 0)
{
wtlen_seas(0, gp, j) = 0.0;
for (s = 1; s <= nseas; s++)
{
wtlen_seas(s, gp, j) = mfexp(MGparm(MGparm_seas_effects(j) + s));
A feasible generic implementation could be:
if abs(Block_type_rd) > 10, then block_type = sign(block_type_rd) * (abs(Block_type_rd) - 10).
then value in tens place would be the control for seasonality. This allows seasonality to be in addition to blocks and trends on base parameter.
The use of abs and sign is because a negative block is the indicator for trend approach.
- count number of Q parameters that request seasonality
- for each of them, create a Q_seas(f,s) parameter.
- check to be sure float is off and check to see that one of the seasons has fixed Q_seas = 0.0 to be the base.
- implement the Q_seas in exp_val where Q as parameter code already is located
https://vscode.dev/github/nmfs-stock-synthesis/stock-synthesis/blob/main/SS_expval.tpl#L398-L399 - Nice to have: check data to see which seasons have obs, then create parameter only for those seasons.
Statistical validity, if applicable
NA
Describe if this is needed for a management application
NA
Additional context
No response
- Dominant language
- C++
- Stars
- 46
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nmfs-ost/ss3-source-code
-
composition in progress
nmfs-ost/ss3-source-code#751 · 1 comment · 1 assignee ·
-
area & movement
nmfs-ost/ss3-source-code#731 · 3 comments · 1 assignee ·
-
misc. output
nmfs-ost/ss3-source-code#723 · 1 assignee ·
-
biology misc. output ongoing
nmfs-ost/ss3-source-code#702 · 1 assignee ·
-
recruitment
nmfs-ost/ss3-source-code#696 · 1 assignee ·
All issues in nmfs-ost/ss3-source-code
Similar issues
-
[BUG] Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
eunomia-bpf/llvmbpf#51 · 1 comment ·
-
status:needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PX4/PX4-Autopilot#28776 ·
-
Website Doc Typo Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 1/5 1-3 hours Newbie friendliness 92/100
autowarefoundation/autoware_universe#13413 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100