[Feature]: Multivariate-Tweedie for age/length compositional likelihood

Open
#266 34 comments 0 reactions 1 assignee View on GitHub

@iantaylor-NOAA is already working on this.

Since Mar 7, 2022.

Assessment

This issue has not been assessed yet.

Description

composition Epic: Data weighting improvement FIMS in progress statistics wishlist

I'm leading a paper with Tim Miller and Brian Stock, introducing a new "multivariate-Tweedie" likelihood for fitting age/length composition data. It is essentially a more flexible alternative to the Dirichlet-multinomial, and appears to have some useful pros and cons relative to the DM. It internally relies upon a dtweedie likeliood, which Johnoel is adding the ADMB-13, so it should be feasible to implement in SS3 by this summer.

Does anyone have sufficient time and interest to work with me to get it implemented (both in logical code, and with a thoughtful user-interface) in SS3?

[Edit: task list below added by Ian on March 24.]
To-do list for MV Tweedie likelihood based on comments above:

  • create new MV-Tweedie-complike branch to host changes code
  • add new likelihood calculation to SS_objfun.tpl and create a pull request (#278)
  • wait until ADMB 13 is released which will include the dtweedie function: https://github.com/admb-project/admb/issues/234
  • double check likelihood calculation added to SS_objfun.tpl by @James-Thorson-NOAA
  • see what parameters need to be created in SS_readdata_330.tpl
  • name parameters in SS_readcontrol_330.tpl (two for mvtweedie compared with one for DM)
  • check everything else is handled automatically (reporting and write_ssnew)
  • document the changes in the SS3 User Manual
  • apply any parallel changes to DM likelihood (discussed in #185 and #219)
  • modify r4ss to work with models that use MV Tweedie
Dominant language
C++
Stars
46
Forks
19
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nmfs-ost/ss3-source-code

All issues in nmfs-ost/ss3-source-code

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.