Sample struct helper function ignoring fleet with only some ghost entries
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 21
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Thanks to @mkapur-noaa for reporting the following issue:
As an aside, our implementation of the helper function didn't get us there at first because we actually had two separate chunks in the .dat file for the same fleet (you can see this here); the first chunk is ghosted (all values are -7) so the helper ignored that fleet entirely, not picking up that there were indeed CAAL entries for that fleet later on (starting on line 792).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the sample struct helper and reproduce the case using the linked Stock Synthesis data.ss example, where one fleet has an all--7 ghost chunk followed by CAAL entries. Done means the helper does not ignore that fleet and recognizes its later CAAL entries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100