nmfs-ost / nmfs-ost/SSMSE

add more parallel options

Open
#152 1 comment 0 reactions 1 assignee View on GitHub

@nathanvaughan-NOAA is already working on this.

Since Jul 25, 2023.

enhancement
Dominant language
R
Stars
21
Forks
14
PR merge metrics
No merged PRs in 30d

Description

Suggestion On Iago's SSMSE JOSS review:

Packages 'foreach' and 'doParallel' are only 'Suggests' in DESCRIPTION, but foreach() is used in package code, although its presence is checked. If option 'parallel=TRUE' is chosen, the code sets up a parallel cluster using parallel::makeCluster, when other backends could be employed, e.g. doFuture. An alternative option would be to import the 'foreach' package, and leave the setup to the user. For example, a Linux user would choose a 'FORK' cluster rather than the default 'PSOCK', for efficiency reasons.

@nathanvaughan-NOAA is working on some other parallel code for another project, so we can build upon his work after it is done.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.