nmfs-ost / nmfs-ost/SSMSE

"replicate" option in future_om_list does not replicate rec_devs when scenarios run in tandem

Open
#144 3 comments 0 reactions 1 assignee View on GitHub

@k-doering-NOAA is already working on this.

Since Dec 16, 2022.

bug
Dominant language
R
Stars
21
Forks
14
PR merge metrics
No merged PRs in 30d

Description

After some digging, I figured out that running multiple scenarios in a single run_SSMSE() call with scen = c("replicate", "all") in the future_om_list doesn't actually make the recruitment deviations in the OM the same across scenarios. If I provide a seed to the run_SSMSE() call and run it separately for each scenario, then I do get the same rec_dev time series.

I've saved an example of this while implementing autocorrelated recruitment to our SardineMSE github here.

I discovered this because I need to call run_SSMSE() separately for our project in order to use multiple different custom HCR functions and that function won't allow you to specify more than one 'custom_MS_source'.

Note: this isn't a problem for situations where all recruitment deviations are provided outside of SSMSE as is done here. In this case, tandem scenarios all have rec_dev time series in common.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.