nmfs-ost / nmfs-ost/SSMSE

Implementation error parameters when stddev=0

Open
#118 1 comment 0 reactions 1 assignee View on GitHub

@k-doering-NOAA is already working on this.

Since Mar 16, 2022.

bug
Dominant language
R
Stars
21
Forks
14
PR merge metrics
No merged PRs in 30d

Description

Old versions of SS3 included implementation error parameters in the forecast for almost all scenarios. In the new versions of SS, implementation parameters are not included unless stddev is >0 in the forecast file. This is causing some old SS models to crash with no helpful debugging output regarding why. We can either catch this in the code and remove the parameters if needed or at least add a warning in the documentation/examples to add a value >0.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.