nitrojs / nitrojs/nitro

Ignore `.DS_Store` files from public assets and compression

Open
#940 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement v2
Dominant language
TypeScript
Stars
11.2k
Forks
899
Avg merge
2d 24m
Merged PRs (30d)
40

Description

Environment

nitro: 2.1.1
node: 18

Reproduction

image

 nitro: {
    compressPublicAssets: true, 
  },
Describe the bug

When the compression option is turned on, there will be .DS_Store.br and .DS_store.gz files in each directory after building.

Can this file be ignored by default?

or some option in config can exclude it.

Additional context

No response

Logs

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the TypeScript implementation for the compressPublicAssets option and trace how public asset paths are selected for compression. Reproduce the reported build with compressPublicAssets enabled and verify that .DS_Store files are excluded from the generated compressed outputs. The issue does not name a test, so add or run the closest existing compression test if one is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.