move `compressPublicAssets` outside prerender
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 11.2k
- Forks
- 899
- Avg merge
- 2d 24m
- Merged PRs (30d)
- 40
Description
Extracted from this comment https://github.com/nitrojs/nitro/issues/4428#issuecomment-4995260455
Running compressPublicAssets at prerender module is wrong, since we can skip prerender process, but still having public assets the consumer wants to compress.
With the new before:close Nitro hook at https://github.com/nitrojs/nitro/pull/4440 we also need to compress assets written after calling the new hook.
I think this is a bug at v3.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the prerender module and every call to compressPublicAssets, then read the before:close Nitro hook introduced in pull request #4440. Trace when public assets are written and compressed. Done means compression no longer depends on prerender running and also covers assets written after the new hook.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100