nitrojs / nitrojs/nitro

v3: fetch() / serverFetch() missing generics

Open
#4,131 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement pending v3
Dominant language
TypeScript
Stars
11.2k
Forks
899
Avg merge
2d 24m
Merged PRs (30d)
40

Description

Describe the feature

The functions fetch() and serverFetch() that nitro provides are missing generic(s) to set Response. Personally I would like to see the same DX as ofetch provides, comparison:

Image

Also I realized that Nitro's fetch doesnt throw an error like ofetch does when the resposne status is not 200.

Additional information

Possibly, shouldnt Nitro provide a patched ofetch with everything starting with / being an internal server fetch?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named; start by locating Nitro's fetch() and serverFetch() entry points and their TypeScript declarations, then compare their response typing and error behavior with ofetch. Done should cover generic response typing and defined non-200 handling, while also resolving whether internal paths should use a patched ofetch.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.