nilbuild / nilbuild/driver.js

Add a correlation between buttons and keyboard

Open
#589 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
26.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Currently, showButtons and disableButtons can be used to specify which buttons are available or not in the popover.
The allowKeyboardControl option allow user to use arrows and escape keys to control the tour.
But its not related to the available buttons, i.e. if the close button is not available, the escape key is still working.

Am I missing something or should we consider a feature request to add a correlation between keyboard control and available buttons ?

Thanks to all contributor for this amazing tool ! I find it clean, easy to use, well documented ! I am currently integrating it in an open-source ERP software, and it will be awesome to be able to design guided tours of the software based on driverjs !

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing showButtons, disableButtons, and allowKeyboardControl in the TypeScript source, then compare how the Escape and arrow-key actions are handled with the configured buttons. The issue does not define the exact correlation, so clarify the intended behavior before changing it; done means keyboard actions consistently respect unavailable buttons and the behavior is covered by the project's existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.