nilbuild / nilbuild/driver.js

Popovers on mobile overlay the highlighted element and ignore position: top

Open
#524 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
26.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

The default positioning behaviour of driver.js seems to cause some issues when on mobile.

I've cut this down to the simplest possible example, which can be viewed in this glitch

https://guiltless-classic-night.glitch.me/

Basically, due to the position and height of the element, driver.js tries to scroll the element into the centre of the viewport, but this then means the popover isn't shown above the selected element anymore - instead it overlays it completely, which (due to the small screen sizes on mobile) hides the content almost entirely.

What's odd is that if you then manually scroll the page, you can get the perfect solution - the tooltip is correctly shown above the top of the selected element

I can't find any way round this at the moment, as the position: top flag seems to be used for guidance and there is no way to "force" it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Glitch reproduction and observe the mobile behavior when the selected element is positioned near the top of the viewport. Trace the positioning and scrolling entry points in driver.js; done means a popover requested with position: top remains above the highlighted element without requiring manual scrolling.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.