nilbuild / nilbuild/driver.js

aria-controls attribute removed during runtime.

Open
#495 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
26.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Issue Summary:
The aria-controls attribute, which is set on certain elements in the HTML, is being unexpectedly removed during runtime when using the driver.js library for creating tours.

Steps to Reproduce:

  1. Set up a webpage with elements that have the aria-controls attribute defined.
  2. Initialize a tour using the driver.js library, targeting elements with aria-controls.
  3. Run the tour and observe that the aria-controls attribute is removed from the elements during runtime.

Expected Behavior:
The aria-controls attribute should remain intact on the elements even after running the tour with driver.js.

Actual Behavior:
The aria-controls attribute is removed from the elements during runtime, which can cause accessibility issues and unexpected behavior on the page.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named. Start by reproducing the tour with an element carrying aria-controls, then trace which runtime operation removes the attribute; done means the attribute remains intact after the tour runs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.