Feature Request: allowClose configs for overlay and close button
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 26.8k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Right now, if allowClose is set as false we lose the ability to dismiss a tour by clicking on the overlay but also from clicking on the close button inside the popover.
I'm making a request to have different configs for both cases, as preventing closing by clicking on the overlay but keeping the close button would be incredibly helpful.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing allowClose handling for overlay clicks and the close button inside the popover. Identify the relevant implementation entry points and tests, then verify that overlay dismissal and close-button dismissal can be configured independently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100