Ideas for things to change/remove in the next major version (2.0)
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 984
- Forks
- 81
- PR merge metrics
- No merged PRs in 30d
Description
- Remove AST_LIST and mark it as deprecated, and remove it whenever AST version 50 is removed.
Related to #94 - It was overlooked
AST_LIST is still used in https://github.com/phan/phan/blob/1.2.2/src/Phan/Analysis/PreOrderAnalysisVisitor.php#L613 (incorrectly, will fix)
- Change the reflection arginfo of ast\parse_code and ast\parse_file to make the int $version mandatory
Remove legacy flags such as ast\flags\RETURNS_REF (alias of ast\flags\FUNC_RETURNS_REF mentioned in README)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the AST_LIST use in src/Phan/Analysis/PreOrderAnalysisVisitor.php and the ast\parse_code, ast\parse_file, and reflection arginfo entry points mentioned in the issue. Check README references to legacy flags, then define completion as the listed deprecated AST_LIST and flag removals and the mandatory version argument being reflected consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100