nikic / nikic/PHP-Parser

Add error nodes for additional missing params?

Open
#616 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
17.5k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Given the following

function bar(object $o) : void {
    $o->foo(
      $one,
      ,
    );
}

there's no MethodCall node - I wonder whether it'd be possible to preserve the node, and allow its args array to contain errors as well as arg objects?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Reproduce the PHP snippet and inspect how the parser handles the missing argument; done means preserving the MethodCall node while representing the missing argument in its args array without losing the other arguments.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.