nightscout / nightscout/AndroidAPS
NSClient V3 Wrong convertion of Extended TBR (minor)
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 1.2k
- Forks
- 6.4k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 19
Description
If source pump support Extended TBR (recorded within NS) but a sync is done on a config with another pump which doesn't support Extended TBR, then convertion si not done correctly:
- Previous standard TBR is not stopped
- Extended TBR is converted to an Extended Bolus, but not with the correct duration.
I found it between loop config and dev config (dev synchronized on my loop with NS3), but use cases should be rare, switch of pump and phone at the same time...)
See screnshot below:
- source data is my loop phone with Insight pump and Extended TBR enabled
- target phone is my dev config with virtual pump, full NS synchronization (Carbs, Bolus, TBR, ...) and loop canceled/disabled.
I was surprised to see wrong IOB on target phone... (root cause of IOB gap was Extended TBR)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the described Nightscout synchronization from an Insight-pump configuration with Extended TBR enabled to a virtual-pump configuration. Trace how Extended TBR records are converted during synchronization; done means the previous standard TBR is stopped, the converted Extended Bolus has the correct duration, and target IOB is accurate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100