[Feature request] "Version x.x.x available" notification should never be sent during the night
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start by locating the VersionCheckerUtilsImpl class and reading triggerCheckVersion and checkVersion to understand how key_last_successful_version_check_timestamp controls the notification. Define the daylight-hours behavior and verify that version notifications are not sent overnight, including appropriate tests for the chosen time boundaries.
Written by the indexing model from the issue text.
Description
As a user, I want the "Version x.x.x available" notification to only be sent during daylight hours so that I am not woken up by non-urgent notifications thanks to AAPS being granted the ability to bypass the Do not disturb feature.
Amateur Technical Comment:
I had a quick look at the code, and it seems my key_last_successful_version_check_timestamp value must be set to 1:46am, resulting in me being woken up at that time every night by the notification. If the VersionCheckerUtilsImpl class' triggerCheckVersion method were to be modified to change any non-daylight time values of key_last_successful_version_check_timestamp, that would avoid the checkVersion method being called when the user is typically asleep.
- Dominant language
- Kotlin
- Stars
- 1.2k
- Forks
- 6.4k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 19
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nightscout/AndroidAPS
-
enhancement for_discussion
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nightscout/AndroidAPS#5057 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 38/100
nightscout/AndroidAPS#5142 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
nightscout/AndroidAPS#5140 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
nightscout/AndroidAPS#5132 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
nightscout/AndroidAPS#5121 · 4 comments ·
All issues in nightscout/AndroidAPS
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Good First Issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
ankidroid/Anki-Android#21942 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
libre-tube/LibreTube#8781 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
MetrolistGroup/Metrolist#4396 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100