nick8325 / nick8325/quickcheck

Arbitrary instance for Char and non-ascii chars

Open
#164 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
790
Forks
130
Avg merge
16h 41m
Merged PRs (30d)
2

Description

while working on Data.Text i noticed that Arbitrary instance for Char just picks a random character from the range (0,255)
because of that, the tests there failed to catch at least 1 bug (https://github.com/bos/text/issues/176)
the tests are weaker than they seem since they don't test the cases where 1 code point is represented by multiple words

a) we can fix the quickcheck package
b) we can have a newtype over Char/String just for Text

does anyone feel strongly about //not// generating non-ascii Chars?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the issue discussion and inspect QuickCheck's Arbitrary instance for Char, then review how Data.Text tests currently generate characters. Decide whether broader character generation belongs in QuickCheck or in a Text-specific newtype; done means an agreed approach that exercises characters represented by multiple words without breaking existing expectations.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
testing-qa
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.