Update-project-version fails when a commit hash is used

Open
#46 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
git, github-actions, python
Domain
ci-cd, devops, tooling

Research direction

Start with the update-project-action implementation and the calling workflow in .github/workflows/publish.yml, then reproduce the failure using the linked Actions run and its Git commands. Trace how a commit hash is resolved to a pull-request base or branch, including the suggested git branch -a --contains <commit> approach. Done means a version-update PR can be created when the input refers to a commit hash.

Written by the indexing model from the issue text.

Description

bug

Bug Report

I ran update-project-version and it failed. We suspect it is because of using a commit hash and not a branch name.

Repro or Code Sample

I don't know why this failed for the couple of releases I did. I'm calling the update-project-action here.

Expected Behavior

Create a PR in the repo for bumping the project version.

Current Behavior

Failure. Here's some log info. See this run.

  [0d9ef0bb-fabf-4858-99fb-2e3fcf7e0035 5b906c0] [319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0] chore: Update project ni.measurements.metadata.v1.proto to v0.1.0.dev4
   Author: dixonjoel <38357562+dixonjoel@users.noreply.github.com>
   1 file changed, 1 insertion(+), 1 deletion(-)
  /usr/bin/git stash push --include-untracked
  No local changes to save
  /usr/bin/git rev-list --right-only --count 319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0...0d9ef0bb-fabf-4858-99fb-2e3fcf7e0035
  1
  /usr/bin/git -c protocol.version=2 fetch --no-tags --progress --no-recurse-submodules --force --depth=11 origin users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0:refs/remotes/origin/users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0
  fatal: couldn't find remote ref users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0
  Pull request branch 'users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0' does not exist yet.
  /usr/bin/git checkout --progress -B users/build/ni.measurements.metadata.v1.proto-update-project-version-319d5ab3ebc8637ee0a3bdd2c38de76c1b597fc0 0d9ef0bb-fabf-4858-99fb-2e3fcf7e0035 --

Possible Solution

@bkeryan suggests this:

I think it could use
git branch -a --contains
to find potential branches
it probably ought to try main first

Context

Your Environment

  • ni/python-actions version
  • Python version

AB#3455360

Dominant language
Python
Stars
2
Forks
0
Avg merge
2d 5h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ni/python-actions

All issues in ni/python-actions

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.