Enable ConfigureLCRCompensation and GetLCRCompensationData in nidcpower GrpcStubInterpreter
Open
Nobody has claimed this yet.
task
- Dominant language
- Python
- Stars
- 128
- Forks
- 110
- Avg merge
- 5d 14h
- Merged PRs (30d)
- 10
Description
Description of issue
For the nimi-python 1.4.4 release, the nidcpower.proto was missing 2 Functions.
This is because of 2 things:
- The metadata for the grpc and nimi-python had the function/method turned off until very close to release (though they were part of a previous NI-DCPower release)
- This meant ni_grpc_device_server.exe on the nimibot runners wouldn't recognize the functions, even if they made it into nidcpower.proto.
- The process for updating the metadata in the grpc-device repo is manual and it happens infrequently.
Once a new ni_grpc_device_server.exe is available on nimibot, we should add these methods by:
- Updating nidcpower.proto
- Removing the overrides in
src/nidcpower/metadata/functions_addon.pythat disable generation of the methods in GrpcStubInterpreter
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First verify that a new ni_grpc_device_server.exe is available on the nimibot runners. Then inspect nidcpower.proto and src/nidcpower/metadata/functions_addon.py; the work is done when ConfigureLCRCompensation and GetLCRCompensationData are present in the proto and no longer disabled from GrpcStubInterpreter generation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100