nifgen system tests don't exercise TypeError throw cases when creating waveforms with numpy
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 128
- Forks
- 110
- Avg merge
- 5d 14h
- Merged PRs (30d)
- 10
Description
Description of issue
The nifgen system-level tests suite doesn't include tests that exercise the TypeError throw cases when creating waveforms with numpy. This was pointed out by @marcoskirsch here: https://github.com/ni/nimi-python/pull/1838/commits/c64c983cd22c0497247b9f1a9945957d3337bc2d#r1013088620
System report
None.
Steps to reproduce issue
Run the system level tests. Try commenting out the TypeError throws in this block, and note that all of the tests still pass.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the TypeError throw block in generated/nifgen/nifgen/session.py around line 1650, then locate the nifgen system-level tests that create waveforms with numpy. Run the system test suite and verify that disabling those throws makes the relevant cases pass; add coverage so each described TypeError case fails without the throws and passes with them enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100