ni / ni/nimi-python

config_addon.py and config.py should merge, not override, custom_types keys.

Open
#1,495 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

codegen
Dominant language
Python
Stars
128
Forks
110
Avg merge
5d 14h
Merged PRs (30d)
10

Description

Description of issue

As encountered in #1485, if there exist custom types in a module's config.py metadata and in the config_addon.py metadata, the config_addon.py will override config.py and only use custom types from config_addon.py in the code generation. These two should be merged instead to allow custom types which rely on C Structs and completely new, python-only custom types to both exist in the generated code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting config.py and config_addon.py to find where custom_types metadata is combined during code generation. Verify how each source is handled, then confirm that generated code retains both C-Struct-dependent custom types and Python-only custom types.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.