ni / ni/nimi-python

`nidmm.Session.get_cal_date_and_time` and `get_last_cal_temp` is different from other nimi-python drivers

Open
#1,462 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

API nidmm
Dominant language
Python
Stars
128
Forks
110
Avg merge
5d 14h
Merged PRs (30d)
10

Description

Description of issue

nidmm.Session.get_cal_date_and_time and get_last_cal_temp are inconsistent with the rest of nimi-python.
Instead of one method that takes in an enum, we should have two methods for each:

  • get_ext_cal_last_date_and_time and get_self_cal_last_date_and_time.
  • get_ext_cal_last_temp and get_self_cal_last_temp
    Note - this inconsistency was inherited from the C/LabVIEW API.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the nidmm.Session implementation and comparing these calibration methods with the corresponding methods in other nimi-python drivers. Check the existing tests and API documentation for the current names; done means the nidmm API follows the established separate-method pattern without losing coverage for external and self-calibration values.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.